Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templateRef): set ref on cached async component which wrapped in KeepAlive #12290

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(templateRef): set ref on cached async component which wrapped in KeepAlive #12290

wants to merge 3 commits into from
+78 −1

Conversation

edison1105
Copy link
Member

close #4999
close #5004

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+103 B) 38 kB (+25 B) 34.2 kB (+55 B)
vue.global.prod.js 159 kB (+103 B) 57.9 kB (+26 B) 51.4 kB (-24 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB (+103 B) 18.3 kB (+19 B) 16.7 kB (+18 B)
createApp 55.1 kB (+103 B) 21.3 kB (+21 B) 19.5 kB (+72 B)
createSSRApp 59.1 kB (+103 B) 23 kB (+19 B) 20.9 kB (+14 B)
defineCustomElement 59.9 kB (+105 B) 22.9 kB (+28 B) 20.8 kB (-45 B)
overall 68.8 kB (+103 B) 26.4 kB (+20 B) 23.9 kB (-41 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 29, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12290

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12290

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12290

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12290

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12290

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12290

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12290

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12290

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12290

vue

pnpm add https://pkg.pr.new/vue@12290

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12290

commit: f56ed5e

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Oct 30, 2024
@edison1105 edison1105 changed the title fix(templateRef): set ref on async component which wrapped in KeepAlive fix(templateRef): set ref on cached async component which wrapped in KeepAlive Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

无法通过ref正确执行懒加载的动态子组件
1 participant
@edison1105